In the Linux kernel, the following vulnerability has been resolved:<\/p>\n
ksmbd: only rebind the reopened file’s own oplock on durable reconnect<\/p>\n
ksmbd_reopen_durable_fd() walks the inode’s m_op_list and rebinds every
\ndetached oplock to the reconnecting session:<\/p>\n
\tlist_for_each_entry_rcu(op, &ci->m_op_list, op_entry,
\n\t\t\t\tlockdep_is_held(&ci->m_lock)) {
\n\t\tif (op->conn)
\n\t\t\tcontinue;
\n\t\top->conn = ksmbd_conn_get(fp->conn);
\n\t\top->sess = work->sess;
\n\t}<\/p>\n
The only key is op->conn == NULL, which every detached durable handle on
\nthat inode matches, not just the one owned by fp. When two sessions hold
\ndurable handles on the same file and both disconnect, reconnecting one of
\nthem adopts the other session’s oplock: op->sess is overwritten with the
\nreconnecting session without taking a reference on it, while op->conn
\npins the connection.<\/p>\n
The sibling teardown path, session_fd_check(), keys on the identity of
\nthe connection being torn down (op->conn == conn) rather than on shared
\nstate, and so does not have this problem.<\/p>\n
Once the adopting session is destroyed, ksmbd_session_destroy() frees it
\nwhile the foreign oplock still points at it. The reader in
\nksmbd_close_fd_app_instance_id() validates only opinfo->conn, which is
\nstill live thanks to the reference taken above, and then dereferences the
\nstale session:<\/p>\n
\tif (!opinfo->conn) {
\n\t\tup_read(&fp->f_ci->m_lock);
\n\t\tgoto out;
\n\t}<\/p>\n
\tft = &opinfo->sess->file_table;
\n\twrite_lock(&ft->lock);<\/p>\n
BUG: KASAN: slab-use-after-free in _raw_write_lock+0x74\/0xd0
\n Write of size 4 at addr ffff88810a970528 by task kworker\/0:0\/9
\n Workqueue: ksmbd-io handle_ksmbd_work
\n Call Trace:
\n _raw_write_lock+0x74\/0xd0
\n ksmbd_close_fd_app_instance_id+0x183\/0x410
\n smb2_open+0x1346\/0x4430
\n handle_ksmbd_work+0x2bb\/0x7b0<\/p>\n
Reached from an authenticated session against a share with the default
\ndurable-handle and oplock configuration: two sessions open the same file
\nwith a durable-v2 handle and an RH lease under distinct AppInstanceIds,
\nboth log off, one reconnects with DH2C, and a later durable-v2 create
\ncarrying the other AppInstanceId walks into the freed session.<\/p>\n
Constrain the loop to the oplock owned by the file being reopened.<\/p>\n","protected":false},"excerpt":{"rendered":"
In the Linux kernel, the following vulnerability has been resolved:<\/p>\n
ksmbd: only rebind the reopened file’s own oplock on durable reconnect<\/p>\n
ksmbd_reopen_durable_fd() walks the inode’s m_op_list and r<\/p>\n","protected":false},"template":"","meta":[],"categories":[],"tags":[],"class_list":["post-21557","vuln","type-vuln","status-publish","hentry"],"_links":{"self":[{"href":"https:\/\/www.54iter.cn\/index.php?rest_route=\/wp\/v2\/vuln\/21557","targetHints":{"allow":["GET"]}}],"collection":[{"href":"https:\/\/www.54iter.cn\/index.php?rest_route=\/wp\/v2\/vuln"}],"about":[{"href":"https:\/\/www.54iter.cn\/index.php?rest_route=\/wp\/v2\/types\/vuln"}],"wp:attachment":[{"href":"https:\/\/www.54iter.cn\/index.php?rest_route=%2Fwp%2Fv2%2Fmedia&parent=21557"}],"wp:term":[{"taxonomy":"category","embeddable":true,"href":"https:\/\/www.54iter.cn\/index.php?rest_route=%2Fwp%2Fv2%2Fcategories&post=21557"},{"taxonomy":"post_tag","embeddable":true,"href":"https:\/\/www.54iter.cn\/index.php?rest_route=%2Fwp%2Fv2%2Ftags&post=21557"}],"curies":[{"name":"wp","href":"https:\/\/api.w.org\/{rel}","templated":true}]}}